zhmcclient / python-zhmcclient / test-4748

77%

push

github

Added mock definitions for SSO Server Definitions (#2227)

* SSOServerDefinition: Added type & add.props query parms; Fixed rename

Details:

* This change has no update to the change log, because the support for
  SSOServerDefinition has not yet been released (targeted for 1.26.0).

* Added 'type' to the query properties of the SSOServerDefinitionManager
  class. That is sufficient to get it supported in the code.

* Added the 'additional_properties' parameter to
  SSOServerDefinitionManager.list(), passing it on to the underlying
  _list_with_operation() method. Thst is sufficient to get it supported in the
  code.

* Fixed the incorrect statement that renames of SSOServerDefinition objects
  would not be allowed, and the corresponding code in
  SSOServerDefinition.update_properties(). That was actually a copy&paste error
  when copying LDAPServerDefinition, where renames are not actually allowed.

* Added 'type' and 'additional-properties' to the query parameters in the mock
  support for "List SSO Server Definitions".

* Added support for the 'properties' query parameter in the mock support for
  "Get SSO Server Definition Properties".

* In the end2end tests for SSOServerDefinition, fixed the mismatch between the
  SSOServerDefinition name that was created and what was actually intended.
  Also, made sure the cleanup deletion gets executed in case of errors right
  in the test function, instead of relying on the next execution of the
  test function (which has code to first clean up a resource that remained from
  the previous run).

* Extended the test_ssosrvdef_find_list() test function to test the
  'additional-properties' query parameter.

* In the end2end test function  test_ssosrvdef_crud(), adjusted the test for
  renaming to now expect success on renaming.

Signed-off-by: Andreas Maier <maiera@de.ibm.com>

* Added mock definitions for SSO Server Definitions

Signed-off-by: Vonteddu Chaithra <Vonteddu.Chaithra1@ibm.com>

* Fix flake8 E501 ... (continued)

1869 of 2888 branches covered (64.72%)

Branch coverage included in aggregate %.

15 of 15 new or added lines in 3 files covered. (100.0%)

9805 of 12222 relevant lines covered (80.22%)

6.41 hits per line