collective / icalendar / 31183013742

98%

push

github

use vBinary.from_ical in Image.data and remove manual base64 decode (#1638)

* use vBinary.from_ical in Image.data and remove manual base64 decode

Image.data was the last place in non-test code that called
base64.b64decode directly. Replace it with vBinary.from_ical so
validation is strict and the error message matches the rest of the
codebase. Remove the now-unreachable else branch in from_property_value
(vText inherits from str so isinstance(value, str) is always true
there) and drop the import.

Signed-off-by: klouds27 <adalwolf@gmail.com>

* address review: restore original news/1550.feature and add own news/1638.feature

Do not edit another contributor's news fragment. Restore news/1550.feature
to its original content crediting @gagana2023 only, and add news/1638.feature
for this PR's specific change.

Signed-off-by: klouds27 <adalwolf@gmail.com>

---------

Signed-off-by: klouds27 <adalwolf@gmail.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>

857 of 877 branches covered (97.72%)

Branch coverage included in aggregate %.

14000 of 14272 relevant lines covered (98.09%)

6.86 hits per line