mendersoftware / mender
76%
master: 80%

LAST BUILD BRANCH: pr_1828
DEFAULT BRANCH: master
Repo Added
Files 145
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH pr_1653
branch: pr_1653
CHANGE BRANCH
x

coverage: 75.684%. Remained the same
1407203572

push

gitlab-ci

kacf 
fix: Fix systemd race condition when restarting mender.

Although somewhat rare, it seems to have more than 50% chance of
happening at least once in one of the state script tests of an
integration test run. What's happening is that when running `systemctl
restart mender-updated` from an `ArtifactReboot` script, systemd kills
the whole control group, including the script. This is fine in itself,
but if the script happens to terminate before Mender does, then it
will be recorded as an error, and the Mender will start on its error
path. What happens afterwards depends on how far it gets before it is
also killed. Usually it will not get further than executing the first
`ArtifactReboot_Error` script, but it could potentially go all the way
to a rollback. Either of those is wrong.

The issue won't affect users of `rootfs-image`, since it uses
`NeedsArtifactReboot=Automatic`, which doesn't call the update
module's `ArtifactReboot`, but it can affect other means of running
`ArtifactReboot`, such as restarting it with systemctl after a package
upgrade.

The best way to mitigate this is to make sure the script survives
longer than Mender. This can be done in the script itself with a shell
`trap` or similar, since systemd sends SIGTERM first. But in order to
make this less surprising for users, switch systemd to kill the client
first in all cases, leaving scripts to be killed only if the
termination times out and it has to resort to SIGKILL.

This started appearing with Yocto scarthgap, and why it has appeared
now is anyone's guess, it could be multiple reasons:
* Exact killing pattern of systemd might have changed slightly.
* The new kernel might kill processes in the same control group
  slightly differently.
Whatever the reason, it causes the script to sometimes terminate
before Mender, causing the issue.

Changelog: Fix systemd race condition when restarting mender from
`ArtifactReboot` script. The symptom would be an error message like:
```
Process returned... (continued)

7109 of 9393 relevant lines covered (75.68%)

11607.37 hits per line

Relevant lines Covered
9393 RELEVANT LINES 7109 COVERED LINES
11607.37 HITS PER LINE
Source Files on pr_1653

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
1407203572 pr_1653 fix: Fix systemd race condition when restarting mender. Although somewhat rare, it seems to have more than 50% chance of happening at least once in one of the state script tests of an integration test run. What's happening is that when running `s... push kacf gitlab-ci
75.68
1402534905 pr_1653 fix: Fix crash when Sync_Leave returns error during a deployment. The problem is that once we have entered the `sync_leave_download` internal state, a deployment has started, and a deployment always has to be ended, to properly clean up. This is ... push kacf gitlab-ci
75.68
See All Builds (2057)