mendersoftware / mender

75%

master: 80%

LAST BUILD ON BRANCH pr_1635

branch: pr_1635

CHANGE BRANCH

x

Reset

• pr_1635
• (HEAD detached at 4c17b4b)
• (HEAD detached at 74712e5)
• (HEAD detached at 968d41f)
• (HEAD detached at c008bca)
• (HEAD detached at ffef645)
• 2.5.0-build2
• 2.6.0-build1
• 3.0.0-build1
• 3.1.0-build3
• 3.1.x
• 3.2.0
• 3.2.0-build2
• 3.2.0-build4
• 3.2.0-build7
• 3.5.0-build6
• 4.0.x
• 5.0.x
• HEAD
• feature-client_auth_api
• feature-partial_updates
• feature-unified_comms
• kacf-test
• lluis-trigger-sync
• master
• pr_1613
• pr_1618
• pr_1621
• pr_1622
• pr_1623
• pr_1624
• pr_1625
• pr_1626
• pr_1627
• pr_1629
• pr_1630
• pr_1631
• pr_1632
• pr_1633
• pr_1634
• pr_1636
• pr_1637
• pr_1638
• pr_1639
• pr_1640
• pr_1641
• pr_1642
• pr_1643
• pr_1644
• pr_1645
• pr_1646
• pr_1647
• pr_1648
• pr_1649
• pr_1650
• pr_1651
• pr_1652
• pr_1653
• pr_1654
• pr_1655
• pr_1656
• pr_1657
• pr_1658
• pr_1659
• pr_1660
• pr_1661
• pr_1662
• pr_1663
• pr_1664
• pr_1666
• pr_1667
• pr_1668
• pr_1669
• pr_1670
• pr_1671
• pr_1672
• pr_1673
• pr_1674
• pr_1675
• pr_1676
• pr_1677
• pr_1678
• pr_1679
• pr_1680
• pr_1681
• pr_1682
• pr_1683
• pr_1684
• pr_1685
• pr_1686
• pr_1687
• pr_1688
• pr_1689
• pr_1690
• pr_1691
• pr_1692
• pr_1693
• pr_1694
• pr_1695
• pr_1696
• pr_1697
• pr_1698
• pr_1699
• pr_1700
• pr_1701
• pr_1702
• pr_1704
• pr_1705
• pr_1706
• pr_1707
• pr_1709
• pr_1710
• pr_1711
• pr_1712
• pr_1713
• pr_1714
• pr_1715
• pr_1716
• pr_1717
• pr_1718
• pr_1719
• pr_1721
• pr_1722
• pr_1723
• pr_1724
• pr_1725
• pr_1726
• pr_1727
• pr_1728
• pr_1729
• pr_1730
• pr_1731
• pr_1733
• pr_1734
• pr_1735
• pr_1736
• pr_1737
• pr_1738
• pr_1739
• pr_1740
• pr_1742
• pr_1743
• pr_1744
• pr_1745
• pr_1746
• pr_1747
• pr_1748
• pr_1749
• pr_1751
• pr_1752
• pr_1753
• pr_1754
• pr_1755
• pr_1756
• pr_1757
• pr_1759
• pr_1760
• pr_1761
• pr_1762
• pr_1763
• pr_1764
• pr_1765
• pr_1766
• pr_1767
• pr_1769
• pr_1770
• pr_1771
• pr_1772
• pr_1773
• pr_1774
• pr_1775
• pr_1776
• pr_1777
• pr_1778
• pr_1779
• pr_1780
• pr_1781
• pr_1782
• pr_1785
• pr_1786
• pr_1787
• pr_1790
• pr_1792
• pr_1793
• pr_1795
• pr_1796
• pr_1798
• pr_1799
• pr_1801
• pr_1802
• pr_1803
• pr_1805
• pr_1806
• pr_1807
• pr_1808
• pr_1809
• pr_1810
• pr_1811
• pr_1812
• pr_1813
• pr_1814
• pr_1815
• pr_1816
• pr_1817
• pr_1820
• pr_1821
• pr_1822
• pr_1823
• pr_1824
• pr_1825
• pr_1826
• pr_1827
• pr_1828
• v0.0.3

Build # 1322289465

Build Type

push

gitlab-ci

Committed by kacf

Commit Message

fix: parse artifact ID before validating payload size

If a deployment fails before the artifact info is parsed, e.g. when a deployment
is started but S3 is blocked by a firewall, the JSON state data describes an
artifact with an empty payload-types list. If mender-update is subsequently
restarted, the JSON state data unmarshaler would exit early and return invalid
state data (empty deployment ID) triggering an assert in
DeploymentClient::PushStatus. The client would never recover from this.

Original-by: Fredrik Ellertsen <fredrik.ellertsen@disruptive-technologies.com>
* https://github.com/mendersoftware/mender/pull/1635

Modified-by: Kristian Amlie <kristian.amlie@northern.tech>
* Fix compile error due to declaration order.
* Made same fix for loading v1 state data.
* Adjusted changelog entry.

Changelog: Fix error which could sometimes happen with restrictive
firewalls, resulting in this output:
```
Programming error, should not happen: Assert `deployment_id != ""`
```

Ticket: MEN-7327

Signed-off-by: Kristian Amlie <kristian.amlie@northern.tech>

Run Details

4 of 4 new or added lines in 1 file covered. (100.0%)

7062 of 9355 relevant lines covered (75.49%)

11651.98 hits per line