pulibrary / bibdata
91%
main: 91%

LAST BUILD BRANCH: signoz_two_electric
DEFAULT BRANCH: main
Repo Added
Files 199
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH index_manager_spec
branch: index_manager_spec
CHANGE BRANCH
x

coverage: 90.522%. Remained the same
7b0881a9-d6d8-4333-bf28-4c0c4993591f

Pull #3281

circleci

christinach 
Update test method to run the batches considering only the parent bid and not the to_a
order of the redis ZRANGE. The ZRANGE to_a order changes in sidekiq-pro 8 to be [child, parent]
so this test method will cause the spec that has an incremental and a full dump to fail
because the parent job will wait for all the children jobs that are inside the block to run and finish.
Then based on that test method it will run last with the sequence of the methods: reindex! will call .wipe! and delete the records that were indexed from the child.

sidekiq-pro gem -> batch.rb Sidekiq::Batch def jobs
notes:
zadd - a redis command that adds a member to a sorted set with a numeric score.
Redis sorted sets store members in order by their score.

Pro 7 — score based when Batch.new was called creation time + expiry:
m.zadd("batches", @created_f + expiry, bid)

Pro 8 — score based when the jobs block finishes, now + expiry:
m.zadd("batches", (Time.now + expiry).to_f, bid)

This difference changes to_a ordering only in tests because of the Sidekiq::Testing.inline!: with inline! the jobs calls perform_async which runs the job synchronously. this job calls index_next_dump
to_a order in pro7 is [parent,child] <- ZRANGE
to_a order in pro8 is [child, parent] <- ZRANGE

In pro7 the test assumes that to_a.last is the child because of the ZRANGE.
In pro8 the parent will not finish until everything inside the parent block has run. because of the ZRANGE if we use to_a.last the parent will wait for everyhting inside to run then it will run last and the reindex! will call .wipe! and delete the records that were indexed from the child. So in this case to_a.last will call the parent.

helps with upgrading sidekiq-pro to 8
https://github.com/pulibrary/bibdata/pull/3280/
Pull Request #3281: Update test method to run the batches considering only the parent bid and not the to_a order

11012 of 12165 relevant lines covered (90.52%)

84.71 hits per line

Relevant lines Covered
12165 RELEVANT LINES 11012 COVERED LINES
84.71 HITS PER LINE
Source Files on index_manager_spec

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
7b0881a9... index_manager_spec Update test method to run the batches considering only the parent bid and not the to_a order of the redis ZRANGE. The ZRANGE to_a order changes in sidekiq-pro 8 to be [child, parent] so this test method will cause the spec that has an incremental ... Pull #3281 christinach circleci
90.52
e66f4c96... index_manager_spec Update test method to run the batches considering only the parent bid and not the to_a order of the redis ZRANGE. The ZRNAGE to_a order changes in sidekiq-pro 8 to be [child, parent] so this test method will cause the spec that has an incremental ... Pull #3281 christinach circleci
90.52
See All Builds (4135)