zopefoundation / transaction

100%

master: 100%

LAST BUILD ON BRANCH issue82

branch: issue82

CHANGE BRANCH

x

Reset

• issue82
• 2.3.0
• 2.4.0
• 3.0.0
• 3.1.0
• 4.0
• 5.0
• abort_hooks_#77
• all-repos_autofix_all-repos-sed
• config-with-pure-python
• config-with-pure-python-template-07964f30
• config-with-pure-python-template-1c2b77e5
• config-with-pure-python-template-6f8d8c51
• config-with-pure-python-template-a8ae60f1
• config-with-pure-python-template-b21fbbf2
• config-with-pure-python-template-b3663390
• docs-take-2
• exc-docs
• fix-deprecation-warning-in-test-suite
• fix-lint
• fix-sphinx-8
• fix-typos
• fix_tm_run#58
• icemac-patch-1
• issue66
• lint
• master
• modern-openssl-please
• modernize-python-versions
• py37
• remove-deprecations
• wrapped-thread-local-208

Build # 293

Build Type

Pull #84

travis-ci

Committed by web-flow

Commit Message

Transaction._free drops more references, and Transaction.abort() is a little safer.

Specifically, free the manager and synchronizers, plus a few other
dictionaries that could be arbitrary size and contain arbitrary data.

And abort() always invokes _free() even in the case of exceptions.
commit() still doesn't so that the synchronizers are available for the
expected abort().

But take care about when and how abort frees its manager: not only
does this preserve backwards compatibility, but it lets it be
safe to abort a transaction object more than once. A happy side-effect
of only freeing the manager there is that synchronizers can access
data they set in afterCompletion().

From discussion in #82

Pull Request Pull Request #84: Transaction._free drops more references, and Transaction.abort() is a bit safer

Run Details

93 of 93 new or added lines in 2 files covered. (100.0%)

3456 of 3456 relevant lines covered (100.0%)

6.99 hits per line