zopefoundation / zope.sendmail
99%
master: 99%

LAST BUILD BRANCH: 7.2
DEFAULT BRANCH: master
Repo Added
Files 15
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH improve-queue-logging
branch: improve-queue-logging
CHANGE BRANCH
x

coverage: 99.43% (+0.001%) from 99.429%
28239136150

Pull #72

github

jensens 
Log data errors via log.error, keep traceback only for unexpected exceptions

Permanent SMTP errors and refused recipients are data problems, not code
errors, so drop the traceback for those and keep log.exception only for
the blanket except handler. Addresses review feedback on #71.
Pull Request #72: Improve logging in QueueProcessorThread (queue.py)

125 of 136 branches covered (91.91%)

Branch coverage included in aggregate %.

14 of 14 new or added lines in 3 files covered. (100.0%)

1793 of 1793 relevant lines covered (100.0%)

1.0 hits per line

Relevant lines Covered
1793 RELEVANT LINES 1793 COVERED LINES
1.0 HITS PER LINE
Source Files on improve-queue-logging

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
28239136150 improve-queue-logging Log data errors via log.error, keep traceback only for unexpected exceptions Permanent SMTP errors and refused recipients are data problems, not code errors, so drop the traceback for those and keep log.exception only for the blanket except handl... Pull #72 jensens github
99.43
28152525896 improve-queue-logging Fix log calls and update tests - Avoid passing 'filename' in logging 'extra' (reserved LogRecord attribute, raised KeyError at runtime); include sender, recipients and queue filename in the message text instead. - Add 'exception' method to Lo... Pull #72 jensens github
99.38
See All Builds (490)