pulibrary / allsearch_api / 968494f1-105d-425e-9cbe-4fdc1bcf32de / 2
100%
main: 100%

LAST BUILD BRANCH: dependabot/bundler/bootsnap-1.20.1
DEFAULT BRANCH: main
Ran
Files 70
Run time 3s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 84.918% (-1.5%) from 86.39%
968494f1-105d-425e-9cbe-4fdc1bcf32de.2

push

circleci

sandbergja 
Remove ActiveRecord-based LibraryDatabaseRecord class

This also improves the performance of loading Library Database metadata from Lib-jobs
by combining all creation into a single INSERT query, rather than running an INSERT
for each row in the CSV.

To confirm, I ran this benchmark before deleting the LibraryDatabaseRecord class:

```
Benchmark.ips do |b|
  library_database_repo = LibraryDatabaseRepository.new Rails.application.config.rom
  csv = CSV.read Rails.root.join('spec/fixtures/files/libjobs/library-databases.csv'), headers: true
  b.report('LibraryDatabaseRecord::new_from_csv') do
    csv.each { LibraryDatabaseRecord.new_from_csv(it)}
    library_database_repo.delete
  end

  b.report('LibraryDatabaseRepository#create_from_csv') do
    library_database_repo.create_from_csv csv
    library_database_repo.delete
  end

  b.compare!
end
```

Results:

```
Warming up --------------------------------------
LibraryDatabaseRecord::new_from_csv
                         3.000 i/100ms
LibraryDatabaseRepository#create_from_csv
                        10.000 i/100ms
Calculating -------------------------------------
LibraryDatabaseRecord::new_from_csv
                         28.764 (±27.8%) i/s   (34.77 ms/i) -    135.000 in   5.004122s
LibraryDatabaseRepository#create_from_csv
                        116.179 (±18.9%) i/s    (8.61 ms/i) -    560.000 in   5.031764s

Comparison:
LibraryDatabaseRepository#create_from_csv:      116.2 i/s
LibraryDatabaseRecord::new_from_csv:       28.8 i/s - 4.04x  slower
```

Closes #402

884 of 1041 relevant lines covered (84.92%)

48.24 hits per line

Source Files on job 968494f1-105d-425e-9cbe-4fdc1bcf32de.2