mendersoftware / mender

81%

master: 81%

LAST BUILD ON BRANCH pr_2006

branch: pr_2006

CHANGE BRANCH

x

Reset

• pr_2006
• (HEAD detached at 4c17b4b)
• (HEAD detached at 74712e5)
• (HEAD detached at 968d41f)
• (HEAD detached at c008bca)
• (HEAD detached at ffef645)
• 2.5.0-build2
• 2.6.0-build1
• 3.0.0-build1
• 3.1.0-build3
• 3.1.x
• 3.2.0
• 3.2.0-build2
• 3.2.0-build4
• 3.2.0-build7
• 3.5.0-build6
• 4.0.x
• 5.0.x
• 5.1.x
• HEAD
• feature-client_auth_api
• feature-partial_updates
• feature-unified_comms
• kacf-test
• lluis-trigger-sync
• master
• pr_1613
• pr_1618
• pr_1621
• pr_1622
• pr_1623
• pr_1624
• pr_1625
• pr_1626
• pr_1627
• pr_1629
• pr_1630
• pr_1631
• pr_1632
• pr_1633
• pr_1634
• pr_1635
• pr_1636
• pr_1637
• pr_1638
• pr_1639
• pr_1640
• pr_1641
• pr_1642
• pr_1643
• pr_1644
• pr_1645
• pr_1646
• pr_1647
• pr_1648
• pr_1649
• pr_1650
• pr_1651
• pr_1652
• pr_1653
• pr_1654
• pr_1655
• pr_1656
• pr_1657
• pr_1658
• pr_1659
• pr_1660
• pr_1661
• pr_1662
• pr_1663
• pr_1664
• pr_1666
• pr_1667
• pr_1668
• pr_1669
• pr_1670
• pr_1671
• pr_1672
• pr_1673
• pr_1674
• pr_1675
• pr_1676
• pr_1677
• pr_1678
• pr_1679
• pr_1680
• pr_1681
• pr_1682
• pr_1683
• pr_1684
• pr_1685
• pr_1686
• pr_1687
• pr_1688
• pr_1689
• pr_1690
• pr_1691
• pr_1692
• pr_1693
• pr_1694
• pr_1695
• pr_1696
• pr_1697
• pr_1698
• pr_1699
• pr_1700
• pr_1701
• pr_1702
• pr_1704
• pr_1705
• pr_1706
• pr_1707
• pr_1709
• pr_1710
• pr_1711
• pr_1712
• pr_1713
• pr_1714
• pr_1715
• pr_1716
• pr_1717
• pr_1718
• pr_1719
• pr_1721
• pr_1722
• pr_1723
• pr_1724
• pr_1725
• pr_1726
• pr_1727
• pr_1728
• pr_1729
• pr_1730
• pr_1731
• pr_1733
• pr_1734
• pr_1735
• pr_1736
• pr_1737
• pr_1738
• pr_1739
• pr_1740
• pr_1742
• pr_1743
• pr_1744
• pr_1745
• pr_1746
• pr_1747
• pr_1748
• pr_1749
• pr_1751
• pr_1752
• pr_1753
• pr_1754
• pr_1755
• pr_1756
• pr_1757
• pr_1759
• pr_1760
• pr_1761
• pr_1762
• pr_1763
• pr_1764
• pr_1765
• pr_1766
• pr_1767
• pr_1769
• pr_1770
• pr_1771
• pr_1772
• pr_1773
• pr_1774
• pr_1775
• pr_1776
• pr_1777
• pr_1778
• pr_1779
• pr_1780
• pr_1781
• pr_1782
• pr_1785
• pr_1786
• pr_1787
• pr_1790
• pr_1792
• pr_1793
• pr_1795
• pr_1796
• pr_1798
• pr_1799
• pr_1801
• pr_1802
• pr_1803
• pr_1805
• pr_1806
• pr_1807
• pr_1808
• pr_1809
• pr_1810
• pr_1811
• pr_1812
• pr_1813
• pr_1814
• pr_1815
• pr_1816
• pr_1817
• pr_1820
• pr_1821
• pr_1822
• pr_1823
• pr_1824
• pr_1825
• pr_1826
• pr_1827
• pr_1828
• pr_1829
• pr_1830
• pr_1831
• pr_1832
• pr_1833
• pr_1834
• pr_1835
• pr_1837
• pr_1838
• pr_1839
• pr_1840
• pr_1841
• pr_1842
• pr_1843
• pr_1844
• pr_1845
• pr_1846
• pr_1847
• pr_1848
• pr_1849
• pr_1850
• pr_1851
• pr_1852
• pr_1853
• pr_1854
• pr_1855
• pr_1856
• pr_1857
• pr_1858
• pr_1859
• pr_1860
• pr_1861
• pr_1863
• pr_1864
• pr_1865
• pr_1866
• pr_1867
• pr_1868
• pr_1869
• pr_1870
• pr_1871
• pr_1872
• pr_1873
• pr_1874
• pr_1875
• pr_1877
• pr_1878
• pr_1879
• pr_1880
• pr_1881
• pr_1882
• pr_1883
• pr_1884
• pr_1885
• pr_1886
• pr_1888
• pr_1889
• pr_1890
• pr_1891
• pr_1892
• pr_1893
• pr_1894
• pr_1895
• pr_1896
• pr_1897
• pr_1898
• pr_1899
• pr_1900
• pr_1901
• pr_1902
• pr_1903
• pr_1904
• pr_1905
• pr_1907
• pr_1908
• pr_1909
• pr_1910
• pr_1911
• pr_1912
• pr_1913
• pr_1914
• pr_1915
• pr_1916
• pr_1917
• pr_1918
• pr_1919
• pr_1920
• pr_1921
• pr_1922
• pr_1924
• pr_1926
• pr_1927
• pr_1928
• pr_1930
• pr_1931
• pr_1932
• pr_1933
• pr_1934
• pr_1935
• pr_1936
• pr_1937
• pr_1938
• pr_1939
• pr_1940
• pr_1941
• pr_1942
• pr_1943
• pr_1944
• pr_1945
• pr_1946
• pr_1947
• pr_1948
• pr_1950
• pr_1951
• pr_1952
• pr_1953
• pr_1954
• pr_1955
• pr_1956
• pr_1957
• pr_1958
• pr_1959
• pr_1960
• pr_1961
• pr_1962
• pr_1963
• pr_1964
• pr_1965
• pr_1967
• pr_1969
• pr_1972
• pr_1973
• pr_1978
• pr_1980
• pr_1981
• pr_1983
• pr_1984
• pr_1996
• pr_1997
• pr_1998
• pr_2001
• v0.0.3

Build # 2727200046

Build Type

push

gitlab-ci

Committed by LudvigAnderson

Commit Message

fix(update-modules): fail the install when the backup fails

`ret=$?` was read inside `if ! <backup>; then`, where `$?` holds the status
of the negated pipeline and is therefore always 0. Both modules exited 0
before applying the payload, so a failed install was reported to the server
as successful: the destination was left untouched while the new software
version was recorded for it. Capture the status from the command itself
instead.

The directory module is the more exposed of the two, since it backs up the
whole destination directory, so any unrelated file growing there can exhaust
the data partition. Reported from the field with a multi-GB core dump.

Add a pytest suite for the shipped update module scripts, alongside the
existing one for the artifact generators, covering both a failing backup and
a successful install for each module. Ignore the Python test caches while
here, since the new suite is the second pytest directory in the tree.

Ticket: MEN-10021
Changelog: Fixed the directory and single-file Update Modules reporting a deployment as
successful when the destination could not be backed up, leaving the destination unchanged.

(cherry picked from commit 8d6f02c81)
Signed-off-by: Ludvig Szklarz Anderson <ludvig.s.anderson@northern.tech>

Coverage Stats

8487 of 10433 relevant lines covered (81.35%)

21663.75 hits per line