mozilla / addons-linter / 6869

100%

push

travis-ci

feat: detect API and manifest key incompatibilities with strict_min_version (#1493) (#2290)

Fixes #1493

This is a first attempt at integrating the browser-compat-data from the MDN compatibility tables with the linter.
It currently checks for manifest keys, permissions and APIs to be supported by the given `strict_min_version` in the manifest for both Firefox and Firefox for Android. All produced messages are warnings. However, no warning is shown if Firefox or Firefox for Android do not implement an API and that is documented in the compat data. This is to avoid a lot of Firefox for Android spam, plus the totally unsupported APIs should be caught by the schemas.

I'm not quite happy with the amount of duplication of logic, even though it's subtly different for all cases, so improvement suggestions welcome! Further I'll happily add more tests, these are just the ones I could come up with.

1052 of 1090 branches covered (96.51%)

64 of 64 new or added lines in 6 files covered. (100.0%)

1871 of 1871 relevant lines covered (100.0%)

922.62 hits per line