pulibrary / orangelight
95%
main: 95%

LAST BUILD BRANCH: dependabot/bundler/rails-8.1.1
DEFAULT BRANCH: main
Repo Added
Files 224
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH memoize-for-advanced
branch: memoize-for-advanced
CHANGE BRANCH
x

coverage: 95.417% (+0.001%) from 95.416%
5ea5ca95-53c2-4fd9-9297-63daf22d05c1

Pull #5308

circleci

sandbergja 
Memoize Bibdata.holding_locations in some helpers

It can take quite some time to read and parse the holding locations from the disk cache.
This can be seen as a bottleneck on both the advanced search form and the search results
page.  Therefore, we should strive not to do this expensive process more than once per
request.

On the advanced form, where the #render_location_code helper method is called once for
every location in the solr index, memoizing Bibdata.holding_locations has a significant
performance gain.  Just running this locally, the server responds with the advanced
search form in half the time!

Microbenchmark before:
```
$ be ruby benchmarks/app/helpers/application_helper.rb
ruby 3.4.1 (2024-12-25 revision 48d4efcb85) +YJIT +PRISM [arm64-darwin24]
Warming up --------------------------------------
ApplicationHelper#render_location_code
                        87.000 i/100ms
Calculating -------------------------------------
ApplicationHelper#render_location_code
                        882.392 (± 1.6%) i/s    (1.13 ms/i) -      4.437k in   5.029587s
```

After:
```
ruby 3.4.1 (2024-12-25 revision 48d4efcb85) +YJIT +PRISM [arm64-darwin24]
Warming up --------------------------------------
ApplicationHelper#render_location_code
                       127.558k i/100ms
Calculating -------------------------------------
ApplicationHelper#render_location_code
                          1.280M (± 1.0%) i/s  (781.40 ns/i) -      6.505M in   5.083919s
```
Pull Request #5308: Memoize Bibdata.holding_locations in some helpers

5 of 6 new or added lines in 1 file covered. (83.33%)

6205 of 6503 relevant lines covered (95.42%)

1462.93 hits per line

Relevant lines Covered
6503 RELEVANT LINES 6205 COVERED LINES
1462.93 HITS PER LINE
Source Files on memoize-for-advanced

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
5ea5ca95... memoize-for-advanced Memoize Bibdata.holding_locations in some helpers It can take quite some time to read and parse the holding locations from the disk cache. This can be seen as a bottleneck on both the advanced search form and the search results page. Therefore, ... Pull #5308 sandbergja circleci
95.42
7667d2fe... memoize-for-advanced Memoize Bibdata.holding_locations in some helpers It can take quite some time to read and parse the holding locations from the disk cache. This can be seen as a bottleneck on both the advanced search form and the search results page. Therefore, ... push sandbergja circleci
95.42
See All Builds (8006)