pulibrary / orangelight
95%
main: 95%

LAST BUILD BRANCH: libmaps_implementation
DEFAULT BRANCH: main
Repo Added
Files 220
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH mobile-layout-shifts
branch: mobile-layout-shifts
CHANGE BRANCH
x

coverage: 95.167%. Remained the same
02babc1a-a52c-42d1-bb6a-a581b9e223e3

Pull #5054

circleci

sandbergja 
Address mobile layout shift

Prior to this commit, the home page of the catalog had a large layout shift visible on
slow connections speeds.  To reproduce:

1. Go to the home page of the catalog
2. In your browser's dev tools, open the network tab
3. Set the throttling to 3g or slower
4. Reload the home page of the catalog
5. Notice that when the content loads, facets are all expanded and at the beginning of the screen.  Later, the facets collapse and move to the top of the screen.

This was due to the blacklight no-js feature, which expands the facets and puts them
at the bottom of the screen before it has determined that JS is enabled.  Once it has
realized JS is enabled, it moves it back into the expected location.  See
https://github.com/projectblacklight/blacklight/pull/2902

This moves the process of determining js support earlier using an inline script tag,
which should block DOM parsing so there is never a time that content is displayed on
the screen before checking JS support. Thanks to @cbeer for suggesting this approach
in https://github.com/projectblacklight/blacklight/pull/2899#issuecomment-1315779289

On my laptop with 3g-speed throttling, lighthouse gave a CLS of 0.81 before this
commit, and 0.054 after it.

This should help with our intermittent lighthouse CI failures as well.
Pull Request #5054: Address mobile layout shift

6085 of 6394 relevant lines covered (95.17%)

1512.86 hits per line

Relevant lines Covered
6394 RELEVANT LINES 6085 COVERED LINES
1512.86 HITS PER LINE
Source Files on mobile-layout-shifts

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
02babc1a... mobile-layout-shifts Address mobile layout shift Prior to this commit, the home page of the catalog had a large layout shift visible on slow connections speeds. To reproduce: 1. Go to the home page of the catalog 2. In your browser's dev tools, open the network tab... Pull #5054 sandbergja circleci
95.17
See All Builds (7514)