pulibrary / orangelight
95%
main: 95%

LAST BUILD BRANCH: many-items
DEFAULT BRANCH: main
Repo Added
Files 224
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH refactor-hidden-fields-item
branch: refactor-hidden-fields-item
CHANGE BRANCH
x

coverage: 95.41% (-0.007%) from 95.417%
0f1e4dec-8a81-44b5-a348-34c75b16e182

Pull #5340

circleci

sandbergja 
Refactor hidden_fields_item helper into its own view component

To me, this is much easier to read as HTML+ERB than the previous
implementation (which used string concatenation and Rails form
helpers).  I think that the tests (which now use Nokogiri, rather
than direct string comparison) will be less brittle to changes
like the order of attributes within a tag.

It is also 4x as fast to avoid the Rails form helpers, for what
it's worth (not that this helper was a bottleneck in any way):

Before:
```
ruby 3.4.1 (2024-12-25 revision 48d4efcb85) +YJIT +PRISM [arm64-darwin24]
Warming up --------------------------------------
Requests::ApplicationHelper#hidden_fields_item
                         2.214k i/100ms
Calculating -------------------------------------
Requests::ApplicationHelper#hidden_fields_item
                         22.325k (± 2.1%) i/s   (44.79 μs/i) -    112.914k in   5.060022s
```

After:
```
ruby 3.4.1 (2024-12-25 revision 48d4efcb85) +YJIT +PRISM [arm64-darwin24]
Warming up --------------------------------------
Requests::ItemHiddenFieldsComponent
                         8.453k i/100ms
Calculating -------------------------------------
Requests::ItemHiddenFieldsComponent
                         84.098k (± 1.3%) i/s   (11.89 μs/i) -    422.650k in   5.026524s
```
Pull Request #5340: Refactor hidden_fields_item helper into its own view component

12 of 12 new or added lines in 1 file covered. (100.0%)

6195 of 6493 relevant lines covered (95.41%)

1467.21 hits per line

Relevant lines Covered
6493 RELEVANT LINES 6195 COVERED LINES
1467.21 HITS PER LINE
Source Files on refactor-hidden-fields-item

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
0f1e4dec... refactor-hidden-fields-item Refactor hidden_fields_item helper into its own view component To me, this is much easier to read as HTML+ERB than the previous implementation (which used string concatenation and Rails form helpers). I think that the tests (which now use Nokogi... Pull #5340 sandbergja circleci
95.41
See All Builds (7760)